Improve whitelist figure description in documentation #8517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for making a pull request to JupyterLab! To try out this branch on binder, follow this link: |
|
Thanks! I think it is clearer with your change as well. |
jasongrout
approved these changes
Jun 4, 2020
saulshanabrook
pushed a commit
that referenced
this pull request
Jun 25, 2020
Improve whitelist figure description in documentation
github-actions
bot
added
the
status:resolved-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The whitelist figure description does not seem to make sense to me. If the extension is whitelisted it should not be removed. It seems to have been copy-pasted from the blacklisted figure description and not adjusted afterwards. Not a native speaker, so may not sound great, just initiating the conversation on this minor point - please feel to propose a better wording.
References
None
Code changes
None
User-facing changes
Before
After
Backwards-incompatible changes
None